Check permissions before running phishing actions #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously an error would be thrown if permissions were missing for a detection action in the phishing module. This PR adds some checks in to ensure the permissions are present in the bot before running those actions. If the permissions aren't present then it will send a warning to the console logs and insert a field to the logging embed that states permissions are missing.
I do have a question, should the checks on ban and kick be seperate to the delete check so that if the bot has one but not the other permission, one of the actions still gets run?
I haven't PR'd the fields to the translations repo yet, wanted to ensure the code was acceptable first.