Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update coins #112

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Update coins #112

merged 5 commits into from
Feb 9, 2024

Conversation

takenagain
Copy link
Collaborator

  • Sync with the latest coins repository changes
  • Add missing coin icons for RTB, SpaceCoin, and TAZ

@takenagain takenagain self-assigned this Feb 8, 2024
@CharlVS CharlVS added the QA Ready for QA testing label Feb 8, 2024
kivqa
kivqa approved these changes Feb 9, 2024
View reviewed changes
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Token list is correct.
FIRO and BCH work as expected.
Swap works as expected for BCH.

smk762
smk762 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New icons visible and correct; BCH functional.
Minor issue created at KomodoPlatform/coins#969 which should not block this PR.

@CharlVS CharlVS merged commit 8e34f0a into dev Feb 9, 2024
1 check passed
@CharlVS CharlVS deleted the update-coins branch February 9, 2024 11:15
This was referenced Feb 9, 2024
Draft
Merged
Merged
ca333 pushed a commit that referenced this pull request May 16, 2024
@takenagain
Update coins (#112) (#115)
866847d 
* Update coins config files and bundled hash

* Add missing coin icons

* Update `coins_config` and bundled hash

* Update `coins_config` and bundled coin hash to `9ab1200`

* Update `space.png`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kivqa kivqa kivqa approved these changes

@CharlVS CharlVS CharlVS approved these changes

@smk762 smk762 smk762 approved these changes

Assignees

@takenagain takenagain

Labels
QA Ready for QA testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takenagain @smk762 @CharlVS @kivqa