Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(best-orders): return an rpc error when we can't find best orders #2318

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

improvement(best-orders): return an rpc error when we can't find best orders #2318

wants to merge 1 commit into from

Conversation

mariocynicys
Copy link
Collaborator

Return an RPC error in best orders rpc if we were not able to get the best orders because nobody in the network replied to our p2p request.
This is saner that returning a successful result with no best orders inside.

Kinda addresses #2228

@mariocynicys
Copy link
Collaborator Author

in progress since i will check also other p2p interacting RPCs and apply the same patch to.
p2p interactions aren't guaranteed to succeed, so we should make that obvious/visible from the RPC side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement: RPC status: in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mariocynicys