Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ResliceRepresentationProxy): add outline to slice geometry #2908

Conversation

jadh4v
Copy link
Collaborator

@jadh4v jadh4v commented Aug 31, 2023

Some applications may want to highlight a the slicing polygon geometry with a colored outline (specially to identify a slice across multiple views). Upgrade the representation proxy to allow for optional rendering of such an outline. Default visibility is off. Exposed properties include outlineColor, outlineVisibility, and outlineLineWidth.

Context

These changes are added during the following VolView development:
Kitware/VolView#359

Results

See red outline in below image:

image

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js: master
    • OS: Windows 11, Pro
    • Browser: Chrome Version 116.0.5845.141 (Official Build) (64-bit)

Some applications may want to highlight a the slicing polygon geometry
with a colored outline (specially to identify a slice across multiple
views). Upgrade the representation proxy to allow for optional
rendering of such an outline. Default visibility is off.
Exposed properties include `outlineColor`, `outlineVisibility`, and
`outlineLineWidth`.
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadh4v jadh4v added this pull request to the merge queue Sep 1, 2023
Merged via the queue into Kitware:master with commit 26bd8da Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

🎉 This PR is included in version 28.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants