Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(annotation-tools): handle radius too small with devicePixelRatio #451

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix(annotation-tools): handle radius too small with devicePixelRatio #451

merged 2 commits into from
Oct 10, 2023

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Oct 9, 2023

No need to scale SVG circle radius by devicePixelRatio.

Before with devicePixelRatio 1
image

Before with devicePixelRatio 2
image

After with devicePixelRatio 1
image

After with devicePixelRatio 2
image

@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2810c61
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/65257d03c850c50008eb326e
😎 Deploy Preview https://deploy-preview-451--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@floryst
Copy link
Collaborator

floryst commented Oct 9, 2023

LGTM overall. I think we should reduce the handle size by half since the handles are now much larger than before.

@PaulHax
Copy link
Collaborator Author

PaulHax commented Oct 10, 2023

No strong opinion on handle size. If reduced, they would get smaller for us devicePixelRatio 1 peeps. Let us keep the 3D handle size the same, and just reduce the visual circle size. That would be like the behavior before for when devicePixelRatio = 2

@floryst
Copy link
Collaborator

floryst commented Oct 10, 2023

Thanks for the clarification, I did mean the visual handle size. The pickable handle size can remain the same.

@PaulHax
Copy link
Collaborator Author

PaulHax commented Oct 10, 2023

Reduced visual handle size to 6 CSS pixels.

image

@floryst
Copy link
Collaborator

floryst commented Oct 10, 2023

LGTM

@floryst floryst merged commit e5dcf4a into Kitware:main Oct 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants