Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spirv tools #3846

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Update spirv tools #3846

merged 3 commits into from
Jan 24, 2025

Conversation

alan-baker
Copy link
Contributor

Update SPIRV-Tools

  • update test expectations

@alan-baker
Copy link
Contributor Author

KhronosGroup/SPIRV-Tools#5958 found validation issues in HLSL codegen

arcady-lunarg
arcady-lunarg approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate that there are even more validation fails now but I guess we will have to fix them at some later point.

@arcady-lunarg arcady-lunarg merged commit bd1f1c2 into KhronosGroup:main Jan 24, 2025
30 checks passed
@alan-baker alan-baker deleted the update-spirv-tools branch January 24, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcady-lunarg arcady-lunarg arcady-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alan-baker @arcady-lunarg