Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSL: Add option to auto-disable rasterization based on Position usage #2439

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

HansKristian-Work
Copy link
Contributor

@HansKristian-Work HansKristian-Work commented Jan 23, 2025

I don't think it's safe to do this as a default since position only needs to be defined if VS is the last pre-raster stage, but fine to make it opt-in.

Fix #2261.

It's not generally safe to return void if position is not written,
there might be subsequent stages that don't care about position.

To avoid any potential breakage, add an option that auto-demotes
instead.
@HansKristian-Work HansKristian-Work merged commit 1a7b7ef into main Jan 23, 2025
10 checks passed
@HansKristian-Work HansKristian-Work deleted the fix-2261 branch January 23, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spriv-cross no longer generates "vertex void" calls for vertex shaders with no outputs.
1 participant