Replace assert of buffer block SPIRType with exception in get_buffer_block_flags
#2376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assert in
ParsedIR::get_buffer_block_flags
is exposed to user code ifCompiler::get_buffer_block_flags
orspvc_compiler_get_buffer_block_decorations
is called with a non-buffer variable (handle).Particularly since the C API has no way of getting a
SPIRType
given only aspvc_variable_id
this should not cause an assertion fail or be ignored but throw an exception.