MSL: Work around broken cube texture gradients on Apple Silicon. #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexaknyazev
reviewed
Nov 27, 2023
HansKristian-Work
requested changes
Nov 27, 2023
...aders-msl/asm/frag/depth-array-texture-lod.lod-as-grad.1d-as-2d.agx-cube-grad.msl23.asm.frag
Show resolved
Hide resolved
To date, all released Apple Silicon GPUs incorrectly interpret the gradient vectors when sampling a cube texture. Specifically, they ignore one of the three partial derivatives in each gradient depending on the selected major axis, and they expect the remaining derivatives to be partially transformed. h/t @lexaknyazev for the code used in the `spvGradientCube()` function. Fixes 8 tests under `dEQP-VK.glsl.texture_functions.texturegrad.*`.
cdavis5e
force-pushed
the
agx-cube-grad-fixup
branch
from
14bea1d to
18976c4
Compare
HansKristian-Work
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To date, all released Apple Silicon GPUs incorrectly interpret the gradient vectors when sampling a cube texture. Specifically, they ignore one of the three partial derivatives in each gradient depending on the selected major axis, and they expect the remaining derivatives to be partially transformed.
h/t @lexaknyazev for the code used in the
spvGradientCube()function.Fixes 8 tests under
dEQP-VK.glsl.texture_functions.texturegrad.*.Also, (unrelated) add missing new MSL options to the C API and the CLI.