Allow to customize float literals in output #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
requested changes
Nov 22, 2023
| { | ||
| public: | ||
| virtual ~FloatFormatter() = default; | ||
| virtual std::string format_float(float value) = 0; |
There was a problem hiding this comment.
Is one needed for fp16, or will that hit the format_float part?
There was a problem hiding this comment.
Currently float16_t will be converted to float before be converted to string:
Lines 5910 to 5913 in 42aac91
I think format_float16 is not needed.
chirsz-ever
force-pushed
the
chirsz/custom-float-formater
branch
from
27c99f3 to
aaddc49
Compare
|
I use "build" subdirectory to generated CMake files, so I added it to .gitignore. Please point out if it conflicts with something. |
chirsz-ever
force-pushed
the
chirsz/custom-float-formater
branch
from
aaddc49 to
20dd53b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change the current behavior. It only works when invoking
set_float_formatter()with initiative.I use
std::shared_ptrto store aFloatFormattervirtual base object, because it can use customized deleter (compare tostd::unique_ptr). Would it be better to just use a raw pointerFloatFormatter*and require the user to keep it valid?Related issues: #2132 #1599