Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement OAuth and patch CN bug #22

Merged
merged 15 commits into from
Jul 19, 2024
Merged

Implement OAuth and patch CN bug #22

merged 15 commits into from
Jul 19, 2024

Conversation

m8rmclaren
Copy link
Collaborator

@m8rmclaren m8rmclaren commented Jul 17, 2024 •
edited
Loading

v1.5.0

Fixes

  • Patched bug that required the allow_any_name or allowed_domains=[""] role parameters to issue/sign certificates with no CN.

Chores

  • Upgrade from Go v1.21 to v1.22.
  • Implement more strict golangci-lint policy.

Features

  • If upstream EJBCA API call fails, the HTTP status code is propogated to the Vault user via the Vault API status code.
  • Implement OAuth 2.0 "client credentials" token flow as a supported authentication mechanism to EJBCA.

@m8rmclaren m8rmclaren added bug Something isn't working enhancement New feature or request labels Jul 17, 2024
m8rmclaren and others added 8 commits July 16, 2024 23:02
@m8rmclaren
chore(lint): Conform to Go 1.22
fc6ed3a 
Signed-off-by: Hayden Roszell <[email protected]>
@m8rmclaren
chore(docs): Conform docs to doctool standard
72aa817 
Signed-off-by: Hayden Roszell <[email protected]>
@m8rmclaren
chore(docs): Refactor docs to discuss OAuth config
00a9e43 
Signed-off-by: Hayden Roszell <[email protected]>
@m8rmclaren
chore(status): Ensure that status is properly progogated in the /role…
88349e2 
… path

Signed-off-by: Hayden Roszell <[email protected]>
@m8rmclaren
chore(ci): Add token for polaris ci
52ed369 
Signed-off-by: Hayden Roszell <[email protected]>
Update generated docs
6868a8c
@m8rmclaren
chore(tests): OAuth unit tests don't need to pull from env
228f3c5 
Signed-off-by: Hayden Roszell <[email protected]>
@m8rmclaren
chore(git): Merge branch 'oauth-cn-bug-58228' of github.com:Keyfactor…
718f947 
…/ejbca-vault-pki-engine into oauth-cn-bug-58228
@m8rmclaren m8rmclaren changed the title chore(oauth): Implement OAuth and patch CN bug Implement OAuth and patch CN bug Jul 17, 2024
fiddlermikey
fiddlermikey approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@fiddlermikey fiddlermikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KarolinHem - we attempted to stick to the template to the best of our ability given our tooling at this time.

@fiddlermikey fiddlermikey merged commit 5219529 into release-1.5 Jul 19, 2024
fiddlermikey added a commit that referenced this pull request Jul 22, 2024
@fiddlermikey @m8rmclaren
Implement OAuth and patch CN bug (#22) (#23)
01c949f 
* chore(oauth): Implement OAuth and patch CN bug
* chore(status): Ensure that status is properly progogated in the /role path

Co-authored-by: Hayden <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiddlermikey fiddlermikey fiddlermikey approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m8rmclaren @fiddlermikey