Feat/update kaoto 2.5.0-M1 #772
Conversation
apupier
force-pushed
the
feat/update-kaoto-2.5.0-M1-testUpdate
branch
from
8858cc0 to
d0e7c0e
Compare
apupier
force-pushed
the
feat/update-kaoto-2.5.0-M1-testUpdate
branch
from
d0e7c0e to
a8d7b11
Compare
Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
feat/update-kaoto-2.5.0-M1-testUpdate
branch
from
a8d7b11 to
328b672
Compare
Signed-off-by: Aurélien Pupier <[email protected]>
|
| @@ -118,7 +118,6 @@ const commonConfig = (env) => { | |||
| alias: { | |||
| "react": path.resolve('./node_modules/react'), | |||
| "react-dom": path.resolve('./node_modules/react-dom'), | |||
| "@patternfly/react-core": path.resolve('./node_modules/@patternfly/react-core') | |||
There was a problem hiding this comment.
@lordrip What is the impact of removing it? (apart from the good news that it allows compilation despite kie using patternfly v4)
There was a problem hiding this comment.
alias offers a way to resolve modules in an easier manner by letting you specify the module name in the code in the way you need and then webpack resolving it to the right module.
In this case, we were bypassing the node resolution by fixing all modules requiring @patternfly/react-core to use the root version of it, this prevented @kie-tools-core/* packages from accessing their patternfly v4 version.
There was a problem hiding this comment.
if I understand well, now if kie-tools-core is using some patternfly component they will use Patternfly v4 for it, right?
(I would need to search in which case they are used and if it can occur in our context to check that it is working)
There was a problem hiding this comment.
Yes, it will and it's happening already for the components used by the hotkeys panel (which we don't see) and the initial loading distractor
apupier
changed the title
|
on hold: discovered that it breaks the Drag'n'drop (only in VS Code...) |
No description provided.