Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Remove sass-loader warnings #754

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

lordrip
Copy link
Member

@lordrip lordrip commented Jan 7, 2025

Context

Currently, when building vscode-kaoto, there are warnings about sass-loader using deprecated APIs.

WARNING in ./node_modules/@kie-tools-core/editor/dist/envelope/styles.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js!./node_modules/@kie-tools-core/editor/dist/envelope/styles.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api

The fix is to update sass-loader to v16

Currently, when building `vscode-kaoto`, there are warnings about
`sass-loader` using deprecated APIs.

```
WARNING in ./node_modules/@kie-tools-core/editor/dist/envelope/styles.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js!./node_modules/@kie-tools-core/editor/dist/envelope/styles.scss)
Module Warning (from ./node_modules/sass-loader/dist/cjs.js):
Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/legacy-js-api
```

The fix is to update `sass-loader` to `v16`
Copy link

sonarqubecloud bot commented Jan 7, 2025

@lordrip lordrip requested review from apupier and djelinek January 7, 2025 16:58
@apupier apupier merged commit 9da3101 into KaotoIO:main Jan 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants