Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kaoto editor in vscode.dev web environment #471

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Fix Kaoto editor in vscode.dev web environment #471

merged 1 commit into from
Jan 30, 2024

Conversation

djelinek
Copy link
Contributor

@djelinek djelinek commented Jan 30, 2024 •
edited
Loading

Screenshot 2024-01-30 at 11 21 31

@djelinek djelinek linked an issue Jan 30, 2024 that may be closed by this pull request
Kaoto doesn't seem to be supported on VSCode web (vscode.dev) #340
Closed
@djelinek djelinek requested a review from apupier January 30, 2024 10:32
apupier
apupier approved these changes Jan 30, 2024
View reviewed changes
src/extension/extensionWeb.ts Outdated Show resolved Hide resolved
apupier
apupier requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@apupier apupier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a note in the changelog

apupier
apupier requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@apupier apupier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups compilation is no more working.

I think it is due to using a shared onstant and it is introducing more dependencies.
So I guess we need to put the constant in a specific file.

If nto working it would require change of webpack config, I think that it is not worthy to investigate on that side for vs code web dev, in this case I woudl suggest to continue to duplicate the regexp

@djelinek
Copy link
Contributor Author

oups compilation is no more working.

I think it is due to using a shared onstant and it is introducing more dependencies. So I guess we need to put the constant in a specific file.

If nto working it would require change of webpack config, I think that it is not worthy to investigate on that side for vs code web dev, in this case I woudl suggest to continue to duplicate the regexp

exactly

apupier
apupier reviewed Jan 30, 2024
View reviewed changes
src/extension/helpers.ts Outdated Show resolved Hide resolved
@djelinek djelinek marked this pull request as ready for review January 30, 2024 15:29
@djelinek djelinek requested a review from apupier January 30, 2024 15:32
@djelinek djelinek merged commit bc48755 into KaotoIO:main Jan 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lordrip lordrip lordrip left review comments

@apupier apupier apupier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kaoto doesn't seem to be supported on VSCode web (vscode.dev)
3 participants
@djelinek @apupier @lordrip