Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify endpoint handling when listening to any IP #613

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Engine/Internal/Infrastructure/Endpoints/EndPoint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ public void Start()
{
Socket = new Socket(Endpoint.AddressFamily, SocketType.Stream, ProtocolType.Tcp);

Socket.SetSocketOption(SocketOptionLevel.IPv6, SocketOptionName.IPv6Only, false);

Socket.Bind(Endpoint);
Socket.Listen(Configuration.Backlog);
}
Expand Down
4 changes: 3 additions & 1 deletion Engine/Shared/Infrastructure/ServerBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ public IServer Build()
}
else
{
endpoints.Add(new EndPointConfiguration(IPAddress.Any, _Port, null, false));
// we cannot bind to both IPv6 and IPv4 on linux
// listening to IPv6 will also listen to IPv4 due to dual-stack
endpoints.Add(new EndPointConfiguration(IPAddress.IPv6Any, _Port, null, false));
}
}

Expand Down
Loading