Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to start working on this, since @V1TA5 named it as a requirement at some point, and I think we should start working on it.
My work as of now was, to replace the gameshort references to the settings file with url parameters or values fetched from the mod itself. At some points this was rather easy and smooth, at others it is a bit hacky and ugly.
There are some more or less breaking changes: The browse routes require the gameshort to be added in front of them now, same for the random mod and mod creation routes.
Generally, I would like to break compatibility with the current routes and add the gameshort in front of every game specific route, even mods and mod creation. The reason is, that it is much easier to have the game supplied by the URL than to add a selection to, lets say, the mod creation dialog. And I think it adds some kind of consistency.
But of course I know that we cannot simply break all mod links that are on the forums and so on. I suggest, that we still add the old mod route, but don't have any templating behind it. Instead, the PHP should query the backend (specifically the /api/adapter/mod/ route), and return a redirect to the URL with the matching gameshort.
Currently this is broken at some point, but I will fix this as soon as I got time