-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
一部TypedArrayがサポートされてないため、dashboardでのmsgpack通信を無効化 #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-compose.ymlのplatformと、frontendのpackage-lock.jsonの対応お願いします
server/docker-compose.yml
Outdated
@@ -33,6 +33,7 @@ services: | |||
retries: 10 | |||
builder: | |||
container_name: wsnet2-builder | |||
platform: linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
platform指定は別PRに分けてもらっていいですか?
Dockerfileも合わせて直さないとなので。
@@ -1,14 +1,13 @@ | |||
{ | |||
"name": "wsnet2-dashboard", | |||
"version": "0.1.0", | |||
"version": "0.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package-lock.jsonの方が"0.1.0"のままです。
ビルドすると差分が出るので、そちらも含めて下さい。
// app.use(express.urlencoded({ extended: true })); | ||
// app.use(msgpack()); | ||
app.use(express.json()); | ||
app.use(express.urlencoded({ extended: true })); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほどjsonでも十分ですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます
Fixes #24.
一部TypedArrayがサポートされてないため、msgpack通信を無効化しました(参考)。
その他変更点まとめ:
npm audit fix
でdashboardの依存パッケージ脆弱性を修正docker-compose.yml
にplatform
指定を追加