Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一部TypedArrayがサポートされてないため、dashboardでのmsgpack通信を無効化 #25

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

superkerokero
Copy link
Collaborator

Fixes #24.

一部TypedArrayがサポートされてないため、msgpack通信を無効化しました(参考)。

  • msgpack-liteの方がサポートされてるTypeは多いようですが、パッケージが古い(6年〜)・decodeAsyncがサポートされてないなどの理由で不採用。
  • カスタム拡張を自作することで対応できそうですが、時間がかかる・frontend/backend両方実装する必要があると難易度が高い。

その他変更点まとめ:

  • npm audit fixでdashboardの依存パッケージ脆弱性を修正
  • M1Macでも動けるよう、docker-compose.ymlplatform指定を追加

@superkerokero superkerokero added the bug Something isn't working label Feb 16, 2023
Copy link
Member

@makiuchi-d makiuchi-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker-compose.ymlのplatformと、frontendのpackage-lock.jsonの対応お願いします

@@ -33,6 +33,7 @@ services:
retries: 10
builder:
container_name: wsnet2-builder
platform: linux/amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform指定は別PRに分けてもらっていいですか?
Dockerfileも合わせて直さないとなので。

@@ -1,14 +1,13 @@
{
"name": "wsnet2-dashboard",
"version": "0.1.0",
"version": "0.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.jsonの方が"0.1.0"のままです。
ビルドすると差分が出るので、そちらも含めて下さい。

// app.use(express.urlencoded({ extended: true }));
// app.use(msgpack());
app.use(express.json());
app.use(express.urlencoded({ extended: true }));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほどjsonでも十分ですね。

Copy link
Member

@makiuchi-d makiuchi-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます

@makiuchi-d makiuchi-d merged commit 302e17f into gopherjs-autobuild Feb 17, 2023
@makiuchi-d makiuchi-d deleted the fix/frontend-property-null branch February 17, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants