Fix breaking label lookup (#588)

* fix breaking label lookup * patch bump * fix tests
JuliaRegistries · Dec 18, 2024 · 3dde8c5 · 3dde8c5 · IanButterworth · Dec 18, 2024
1 parent f1b87a6
commit 3dde8c5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "RegistryCI"
 uuid = "0c95cc5f-2f7e-43fe-82dd-79dbcba86b32"
 authors = ["Dilum Aluthge <[email protected]>", "Fredrik Ekre <[email protected]>", "contributors"]
-version = "10.10.1"
+version = "10.10.2"
 
 [deps]
 Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

diff --git a/src/AutoMerge/cron.jl b/src/AutoMerge/cron.jl
@@ -2,6 +2,7 @@ using GitHub: GitHub
 
 const OVERRIDE_BLOCKS_LABEL = "Override AutoMerge: ignore blocking comments"
 const BLOCKED_LABEL = "AutoMerge: last run blocked by comment"
+const BREAKING_LABEL = "BREAKING"
 
 function all_specified_statuses_passed(
     api::GitHub.GitHubAPI,

diff --git a/src/AutoMerge/guidelines.jl b/src/AutoMerge/guidelines.jl
@@ -369,7 +369,7 @@ function breaking_explanation_message(has_release_notes)
 end
 
 function meets_breaking_explanation_check(labels::Vector, body::AbstractString)
-    if any(==("BREAKING"), labels)
+    if has_label(labels, BREAKING_LABEL)
         release_notes = get_release_notes(body)
         if release_notes === nothing
             msg = breaking_explanation_message(false)

diff --git a/test/automerge-unit.jl b/test/automerge-unit.jl
@@ -351,11 +351,11 @@ end
         <!-- END RELEASE NOTES -->
         """
         body_bad_no_notes = ""
-
-        @test AutoMerge.meets_breaking_explanation_check(["BREAKING"], body_good)[1]
-        @test AutoMerge.meets_breaking_explanation_check(["BREAKING"], body_good_changelog)[1]
-        @test !AutoMerge.meets_breaking_explanation_check(["BREAKING"], body_bad)[1]
-        @test !AutoMerge.meets_breaking_explanation_check(["BREAKING"], body_bad_no_notes)[1]
+        breaking_label = GitHub.Label(; name="BREAKING")
+        @test AutoMerge.meets_breaking_explanation_check([breaking_label], body_good)[1]
+        @test AutoMerge.meets_breaking_explanation_check([breaking_label], body_good_changelog)[1]
+        @test !AutoMerge.meets_breaking_explanation_check([breaking_label], body_bad)[1]
+        @test !AutoMerge.meets_breaking_explanation_check([breaking_label], body_bad_no_notes)[1]
 
         # Maybe this should fail as the label isn't applied by JuliaRegistrator, so the version isn't breaking?
         @test AutoMerge.meets_breaking_explanation_check([], body_good)[1]