Fix set_step_increment! (#75)

* Fix set_step_increment! Was incorrectly setting the global step instead. * bump version Co-authored-by: Brian Chen <[email protected]>
JuliaLogging · Aug 28, 2020 · c2c0906 · c2c0906 · PhilipVinc · Aug 28, 2020
1 parent febbad6
commit c2c0906
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "TensorBoardLogger"
 uuid = "899adc3e-224a-11e9-021f-63837185c80f"
 authors = ["Filippo Vicentini <[email protected]>"]
-version = "0.1.10"
+version = "0.1.11"
 
 [deps]
 CRC32c = "8bf52ea8-c179-5cab-976a-9e18b702a9bc"

diff --git a/src/TBLogger.jl b/src/TBLogger.jl
@@ -174,7 +174,7 @@ each time logging is performed.
 
 Can be overidden by passing `log_step_increment=some_increment` when logging.
 """
-set_step_increment!(lg::TBLogger, step) = lg.global_step = step
+set_step_increment!(lg::TBLogger, Δstep) = lg.step_increment = Δstep
 
 """
 	increment_step!(lg, Δ_Step) -> Int

diff --git a/test/test_TBLogger.jl b/test/test_TBLogger.jl
@@ -67,6 +67,10 @@ end
 
     @test set_step!(tbl, 1) == 1
     @test tb_step(tbl) == 1
+
+    @test set_step_increment!(tbl, 10) == 10
+    # changing the increment should not affect the step
+    @test tb_step(tbl) == 1
 end
 
 @testset "resetting" begin