Fix erroneous MSC(h) and improve accuracy of MSC(h, l) (#349)
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimikage
commented
Sep 14, 2019
| @@ -247,15 +239,55 @@ end | |||
|
|
|||
| # Maximally saturated color for a specific hue and lightness | |||
| # is found by looking for the edge of LCHuv space. | |||
| function MSC(h,l) | |||
| pmid=MSC(h) | |||
| function MSC(h, l; linear::Bool=false) | |||
There was a problem hiding this comment.
I was debating but decided to set the default value of linear to false. The reasons are as follows.
- Since the bug fix of
MSC(h)(gamma) is a slightly breaking change, it is no longer important whetherMSC(h, l)involves breaking. - The differences are perceptually insignificant for the preset colormaps.
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
==========================================
+ Coverage 72.51% 74.06% +1.55%
==========================================
Files 10 10
Lines 764 775 +11
==========================================
+ Hits 554 574 +20
+ Misses 210 201 -9
Continue to review full report at Codecov.
|
kimikage
changed the title
MSC(h) and improve accuracy of MSC(h, l)MSC(h) and improve accuracy of MSC(h, l) (#349)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This focuses primarily on bug fixes mentioned in #349, and the Interface improvements are future tasks.
Therefore, the interfaces remain except the additional keyword argument
linear.