Replace epsilon with epsilon / 2 (#83)

* Replace epsilon with epsilon / 2 * Patch version * Fix tutorial
JuliaDecisionFocusedLearning · Jul 3, 2023 · 44a3055 · 44a3055
1 parent b9f4f69
commit 44a3055
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/CITATION.bib b/CITATION.bib
@@ -2,7 +2,7 @@ @misc{InferOpt.jl
 	author  = {Guillaume Dalle, Léo Baty, Louis Bouvier and Axel Parmentier},
 	title   = {InferOpt.jl},
 	url     = {https://github.com/axelparmentier/InferOpt.jl},
-	version = {v0.5.0},
+	version = {v0.5.1},
 	year    = {2023},
 	month   = {7}
 }
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "InferOpt"
 uuid = "4846b161-c94e-4150-8dac-c7ae193c601f"
 authors = ["Guillaume Dalle", "Léo Baty", "Louis Bouvier", "Axel Parmentier"]
-version = "0.5.0"
+version = "0.5.1"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

diff --git a/docs/Manifest.toml b/docs/Manifest.toml
@@ -407,7 +407,7 @@ version = "0.4.10"
 deps = ["ChainRulesCore", "LinearAlgebra", "Random", "Statistics", "StatsBase", "ThreadsX"]
 path = ".."
 uuid = "4846b161-c94e-4150-8dac-c7ae193c601f"
-version = "0.5.0-DEV"
+version = "0.5.1"
 
     [deps.InferOpt.extensions]
     InferOptFrankWolfeExt = "DifferentiableFrankWolfe"

diff --git a/examples/tutorial.jl b/examples/tutorial.jl
@@ -96,7 +96,7 @@ Here is the crucial part where InferOpt.jl intervenes: the choice of a clever lo
 - evaluate the quality of our model based on the paths that it recommends
 =#
 
-layer = PerturbedMultiplicative(linear_maximizer; ε=1.0, nb_samples=5);
+layer = PerturbedMultiplicative(linear_maximizer; ε=0.1, nb_samples=5);
 loss = FenchelYoungLoss(layer);
 
 #=

diff --git a/src/imitation/fenchel_young_loss.jl b/src/imitation/fenchel_young_loss.jl
@@ -105,7 +105,7 @@ function fenchel_young_F_and_first_part_of_grad(
     perturbed::PerturbedMultiplicative, θ::AbstractArray, Z::AbstractArray; kwargs...
 )
     (; maximizer, ε) = perturbed
-    eZ = exp.(ε .* Z .- ε^2)
+    eZ = exp.(ε .* Z .- ε^2 ./ 2)
     θ_perturbed = θ .* eZ
     y = maximizer(θ_perturbed; kwargs...)
     F = dot(θ_perturbed, y)

diff --git a/src/perturbed/multiplicative.jl b/src/perturbed/multiplicative.jl
@@ -52,7 +52,7 @@ function perturb_and_optimize(
     perturbed::PerturbedMultiplicative, θ::AbstractArray, Z::AbstractArray; kwargs...
 )
     (; maximizer, ε) = perturbed
-    θ_perturbed = θ .* exp.(ε .* Z .- ε^2)
+    θ_perturbed = θ .* exp.(ε .* Z .- ε^2 ./ 2)
     y = maximizer(θ_perturbed; kwargs...)
     return y
 end