Skip to content

Commit

Permalink
Drop EXPOSE from Dockerfile (hyperledger-labs#302)
Browse files Browse the repository at this point in the history
There doesn't seem to be a good way to make this respect a param or
envvar passed in, and it's not strictly needed if you're mapping ports.

Having it be present & incorrect in some cases is worse than having it
be absent in some cases where it would be correct. So just drop it
entirely.

Signed-off-by: Jacob Kopczynski <[email protected]>
  • Loading branch information
jkopczyn authored May 12, 2022
1 parent f553332 commit 4252af2
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,5 @@ COPY --from=BUILD_IMAGE $EXPLORER_APP_PATH/dist ./app/
COPY --from=BUILD_IMAGE $EXPLORER_APP_PATH/client/build ./client/build/
COPY --from=BUILD_IMAGE $EXPLORER_APP_PATH/node_modules ./node_modules/

# expose default ports
EXPOSE 8080

# run blockchain explorer main app
CMD npm run app-start && tail -f /dev/null

0 comments on commit 4252af2

Please sign in to comment.