feat: handle arbitrary transaction motion #304
Conversation
Nortsova
force-pushed
the
feat/3536-arbitrary-motion
branch
2 times, most recently
from
0e26955 to
e0db2b5
Compare
Nortsova
force-pushed
the
feat/3536-arbitrary-motion
branch
from
e0db2b5 to
de081f2
Compare
| @@ -52,7 +52,6 @@ export default async (event: ContractEvent): Promise<void> => { | |||
| await writeActionFromEvent(event, colonyAddress, { | |||
| type: ColonyActionType.MakeArbitraryTransaction, | |||
| initiatorAddress: receipt.from, | |||
| recipientAddress: receipt.to, | |||
| fromDomainId: getDomainDatabaseId(colonyAddress, Id.RootDomain), | |||
There was a problem hiding this comment.
I'm not sure we actually need this as it is only possible to create arbitrary transactions in the root domain, although looking at some of the other actions we use this fromDomainId even if can only be created in the root domain so maybe it is still required.
There was a problem hiding this comment.
That's a good point, there's no concept of domain when it comes to arbitrary transactions. I would opt for removing this to avoid confusion.
| @@ -52,7 +52,6 @@ export default async (event: ContractEvent): Promise<void> => { | |||
| await writeActionFromEvent(event, colonyAddress, { | |||
| type: ColonyActionType.MakeArbitraryTransaction, | |||
| initiatorAddress: receipt.from, | |||
| recipientAddress: receipt.to, | |||
| fromDomainId: getDomainDatabaseId(colonyAddress, Id.RootDomain), | |||
There was a problem hiding this comment.
That's a good point, there's no concept of domain when it comes to arbitrary transactions. I would opt for removing this to avoid confusion.
| @@ -52,7 +52,6 @@ export default async (event: ContractEvent): Promise<void> => { | |||
| await writeActionFromEvent(event, colonyAddress, { | |||
| type: ColonyActionType.MakeArbitraryTransaction, | |||
| initiatorAddress: receipt.from, | |||
| recipientAddress: receipt.to, | |||
There was a problem hiding this comment.
I see what you mean now, it makes sense to remove this as it would always point to the colony rather than the target contract address of the arbitrary transaction.
This PR is cover JoinColony/colonyCDapp#3536 and could be tested in scope of JoinColony/colonyCDapp#3933