-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proxy colonies] Feat: Add create event details to colony model #303
[Proxy colonies] Feat: Add create event details to colony model #303
Conversation
885031e
to
754ae12
Compare
Feat: Add create event details to colony model
754ae12
to
9f9904a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and simple, good stuff :)
Just one comment / question about error handling. Not 100% sure about the best way to go about it tbh, might need some discussion.
.getTransaction(transactionHash); | ||
signerAddress = transaction.from; | ||
} catch (error) { | ||
// Most likely there was an error retrieving this transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to bail out of the whole handler if this fails? Or at least log an error or something? I guess it's not critical to the colony creation process (only proxy colonies later down the line) so maybe bailing out is too severe? 🤷
93f5d6c
to
cea3572
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since we worked on it together 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tested in scope of JoinColony/colonyCDapp#3920 🙌
This PR addresses adding the colony create event details to the
Colony
model upon colony creation.This information is needed for easily deploying new Proxy Colonies.
CDapp PR
Scripts PR