Add composite key support to Model.exists?

Fix rails#51295
JoeDupuis · Mar 12, 2024 · f9f3350 · f9f3350
1 parent 4d3e291
commit f9f3350
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb
@@ -444,8 +444,7 @@ def construct_relation_for_exists(conditions)
           relation = except(:select, :distinct, :order)._select!(ONE_AS_ONE).limit!(1)
         end
 
-        case conditions
-        when Array, Hash
+        if conditions.is_a?(Array) && !conditions.first.is_a?(Array) || conditions.is_a?(Hash)
           relation.where!(conditions) unless conditions.empty?
         else
           relation.where!(primary_key => conditions) unless conditions == :none

diff --git a/activerecord/test/cases/finder_test.rb b/activerecord/test/cases/finder_test.rb
@@ -195,11 +195,14 @@ def test_exists
     assert_equal true, Topic.exists?(author_name: "Mary", approved: true)
     assert_equal true, Topic.exists?(["parent_id = ?", 1])
     assert_equal true, Topic.exists?(id: [1, 9999])
+    assert_equal true, Cpk::Book.exists?([cpk_books(:cpk_great_author_first_book).id])
 
     assert_equal false, Topic.exists?(45)
     assert_equal false, Topic.exists?(9999999999999999999999999999999)
     assert_equal false, Topic.exists?(Topic.new.id)
+    assert_equal false, Cpk::Book.exists?([Cpk::Book.new.id])
 
+    assert_raises(ArgumentError) { Cpk::Book.exists?(cpk_books(:cpk_great_author_first_book).id) }
     assert_raise(ArgumentError) { Topic.exists?([1, 2]) }
   end