Add composite key support to Model.exists?

Fix rails#51295
JoeDupuis · Mar 12, 2024 · 760c6f5 · 760c6f5
1 parent 4d3e291
commit 760c6f5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb
@@ -444,11 +444,11 @@ def construct_relation_for_exists(conditions)
           relation = except(:select, :distinct, :order)._select!(ONE_AS_ONE).limit!(1)
         end
 
-        case conditions
-        when Array, Hash
+        if conditions.is_a?(Array) && conditions.first.is_a?(String) || conditions.is_a?(Hash)
           relation.where!(conditions) unless conditions.empty?
         else
-          relation.where!(primary_key => conditions) unless conditions == :none
+          conditions = [conditions] if klass.composite_primary_key?
+          relation.where!(primary_key => conditions) unless conditions == :none || conditions.empty?
         end
 
         relation