-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): unified metrics endpoint #1616
feat(server): unified metrics endpoint #1616
Conversation
For some reason the metrics from prometheus are now coming back empty - in the process of debugging |
Ah okay, I just didn't understand how prometheus works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one minor thing. Also, please make sure this is still working by running a server and checking the API.
|
||
/experimental/server/metrics: | ||
get: | ||
tags: Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tags is a list, so I think this should have been
tags:
- Server
See the issue at https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/Jigsaw-Code/outline-server/master/src/shadowbox/server/api.yml
location and stuff look like that because i didn't run it on docker yet (no IP tables)