Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): unified metrics endpoint #1616

Merged
merged 13 commits into from
Nov 22, 2024

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Nov 8, 2024

location and stuff look like that because i didn't run it on docker yet (no IP tables)

Screenshot 2024-11-11 at 6 16 59 PM

@github-actions github-actions bot added the size/S label Nov 8, 2024
@github-actions github-actions bot added size/M and removed size/S labels Nov 11, 2024
@github-actions github-actions bot added size/L and removed size/M labels Nov 12, 2024
@daniellacosse daniellacosse marked this pull request as ready for review November 12, 2024 00:10
src/shadowbox/server/mocks/mocks.ts Outdated Show resolved Hide resolved
src/shadowbox/server/mocks/mocks.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_service.ts Show resolved Hide resolved
src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
@fortuna fortuna requested a review from sbruens November 13, 2024 23:51
@fortuna fortuna self-requested a review November 13, 2024 23:54
src/shadowbox/server/manager_metrics.spec.ts Show resolved Hide resolved
src/shadowbox/server/manager_metrics.spec.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
@fortuna fortuna self-requested a review November 14, 2024 19:03
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Outdated Show resolved Hide resolved
@daniellacosse
Copy link
Contributor Author

daniellacosse commented Nov 15, 2024

For some reason the metrics from prometheus are now coming back empty - in the process of debugging

@daniellacosse
Copy link
Contributor Author

For some reason the metrics from prometheus are now coming back empty - in the process of debugging

Ah okay, I just didn't understand how prometheus works. increase() requires two separate data points to return a value (the difference between the two points). I was calling increase() when there was only one data point, resulting in zero.

Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor thing. Also, please make sure this is still working by running a server and checking the API.

src/shadowbox/server/api.yml Outdated Show resolved Hide resolved
src/shadowbox/server/manager_metrics.ts Show resolved Hide resolved
src/shadowbox/server/manager_service.ts Outdated Show resolved Hide resolved
@daniellacosse
Copy link
Contributor Author

Screenshot 2024-11-21 at 4 48 35 PM

@daniellacosse daniellacosse merged commit 9d9f76b into master Nov 22, 2024
11 checks passed
@daniellacosse daniellacosse deleted the daniellacosse/unified_server_metrics_endpoint branch November 22, 2024 22:33

/experimental/server/metrics:
get:
tags: Server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants