feat(server): add tunnel time metric to opt-in server usage report #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruens
force-pushed
the
sbruens/optin-metrics-tunneltime
branch
from
87800fa to
8a911f0
Compare
fortuna
approved these changes
May 21, 2024
Base automatically changed from
sbruens/optin-metrics
to
sbruens/refactor-tests
October 16, 2024 14:05
sbruens
force-pushed
the
sbruens/optin-metrics-tunneltime
branch
from
6ed7585 to
5341e1a
Compare
sbruens
changed the base branch from
sbruens/refactor-tests
to
sbruens/optin-asn
fortuna
reviewed
Oct 16, 2024
sbruens
force-pushed
the
sbruens/optin-metrics-tunneltime
branch
from
cbf2e21 to
aa8f8f2
Compare
sbruens
force-pushed
the
sbruens/optin-metrics-tunneltime
branch
from
aa8f8f2 to
94c2219
Compare
sbruens
commented
Oct 17, 2024
fortuna
approved these changes
Oct 18, 2024
| usage.push({country, inboundBytes, asn}); | ||
| // Return both data bytes and tunnel time information with a single | ||
| // Prometheus query, by using a custom "metric_type" label. | ||
| const queryResponse = await this.prometheusClient.query(` |
There was a problem hiding this comment.
I think this is an ok solution, though I don't consider good practice to mix data of different types. Here we are creating a single time series with different units and meaning. And later split them again. I'd rather keep them as separate time series, as it's a lot clearer.
I also wonder if this approach affects performance somehow.
There was a problem hiding this comment.
@fortuna Ok let me try something else. How about this?
fortuna
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.