Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sentry_webhook): rollback Salesforce value changes #1461

Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix(sentry_webhook): rollback Salesforce value changes #1461

merged 3 commits into from
Dec 11, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Dec 11, 2023 •
edited
Loading

Rolling back #1419. This is a likely culprit of Salesforce not creating cases.

@sbruens sbruens requested a review from a team as a code owner December 11, 2023 20:29
@sbruens sbruens changed the title fix(sentry_webhook): Rollback Salesforce ID changes fix(sentry_webhook): rollback Salesforce value changes Dec 11, 2023
daniellacosse
daniellacosse requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@daniellacosse daniellacosse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're gonna have to set the node engines version to 18.x.x - see my email entitled "It seems the required node version shifted in the Github Action without warning." Otherwise looks good.

@sbruens
Copy link
Contributor Author

sbruens commented Dec 11, 2023

You're gonna have to set the node engines version to 18.x.x - see my email entitled "It seems the required node version shifted in the Github Action without warning." Otherwise looks good.

Done.

daniellacosse
daniellacosse approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending whatever the hell is going on, sorry

@sbruens
Copy link
Contributor Author

sbruens commented Dec 11, 2023

I think I have a fix for whatever is failing in #1462. I have no idea why it only started failing today. Maybe some cache of OmahaProxy has finally expired?

@sbruens sbruens merged commit 2a30486 into master Dec 11, 2023
13 checks passed
@sbruens sbruens deleted the sbruens/fix-sentry branch December 11, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbruens @daniellacosse