Return nullability of editor in action

JetBrains · Jul 29, 2024 · bd53a89 · bd53a89
1 parent e61fed2
commit bd53a89
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/main/java/com/maddyhome/idea/vim/helper/IjActionExecutor.kt b/src/main/java/com/maddyhome/idea/vim/helper/IjActionExecutor.kt
@@ -66,7 +66,7 @@ internal class IjActionExecutor : VimActionExecutor {
    * @param ijAction  The action to execute
    * @param context The context to run it in
    */
-  override fun executeAction(editor: VimEditor, action: NativeAction, context: ExecutionContext): Boolean {
+  override fun executeAction(editor: VimEditor?, action: NativeAction, context: ExecutionContext): Boolean {
     val ijAction = (action as IjNativeAction).action
 
     /**
@@ -77,7 +77,10 @@ internal class IjActionExecutor : VimActionExecutor {
     dataContext.putUserData(runFromVimKey, true)
 
     val contextComponent = PlatformCoreDataKeys.CONTEXT_COMPONENT.getData(dataContext)
-      ?: editor.ij.component
+      ?: editor?.ij?.component ?: run {
+        LOG.error("Cannot get context component")
+        return false
+      }
 
     val result = withRunningAction {
       val result = withStringRegistryOption {

diff --git a/vim-engine/src/main/kotlin/com/maddyhome/idea/vim/api/VimActionExecutor.kt b/vim-engine/src/main/kotlin/com/maddyhome/idea/vim/api/VimActionExecutor.kt
@@ -27,7 +27,7 @@ interface VimActionExecutor {
    * @param action  The action to execute
    * @param context The context to run it in
    */
-  fun executeAction(editor: VimEditor, action: NativeAction, context: ExecutionContext): Boolean
+  fun executeAction(editor: VimEditor?, action: NativeAction, context: ExecutionContext): Boolean
 
   /**
    * Execute an action by name