Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bundle): use named_parameters rather than parameters #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

npfp
Copy link
Contributor

@npfp npfp commented Jan 16, 2025

This PR replaces use of parameters by named_parameters in the task definition.

Screenshot 2025-01-16 at 23 27 21 See https://docs.databricks.com/api/workspace/jobs/create

The purpose of this change is to benefit of making job parameters available as task parameters:

Screenshot 2025-01-16 at 23 28 35 https://docs.databricks.com/en/jobs/task-parameters.html

Using job parameters as task parameters would give the ability to define a params argument at the databricks job level that would be passed from the databricks job to the databricks tasks and so it would give the ability to use the kedro runtime_params: resolver.

Copy link

codeclimate bot commented Jan 16, 2025

Code Climate has analyzed commit 3180f9b and detected 0 issues on this pull request.

View more on Code Climate.

@npfp
Copy link
Contributor Author

npfp commented Jan 16, 2025

I haven't implemented the tests yet, because I first wanted to discuss the implementation with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant