feat: add var argument to kedro databricks deploy cli #77
Conversation
theoclipse
force-pushed
the
feat/add-var-argument
branch
4 times, most recently
from
05bbe06 to
5ac80f5
Compare
| @@ -117,6 +117,7 @@ def bundle( | |||
| @click.option("-c", "--conf", default=DEFAULT_CONF_FOLDER, help=CONF_HELP) | |||
| @click.option("-d", "--debug/--no-debug", default=False, help="Enable debug mode") | |||
| @click.option("-p", "--pipeline", default=None, help="Bundle a single pipeline") | |||
| @click.option("-v", "--var", default=None, help="set values for variables defined in bundle config. Example: --var=\"foo=bar\"") | |||
There was a problem hiding this comment.
So Databricks allows you to pass this multiple times.... should we do the same?
There was a problem hiding this comment.
Good question, did not see it was possible.
I would say we should do as they do since we are trying to replicate what is doing databricks cli. What do you think?
There was a problem hiding this comment.
We should 😊 this was such a minor addition I actually implemented it yesterday when I was doing some or refactoring. See PR #80.
It just needs tests before it can be merged
There was a problem hiding this comment.
I saw the MR, it s perfect, thank you for that!
Signed-off-by: theo <[email protected]>
theoclipse
force-pushed
the
feat/add-var-argument
branch
from
5ac80f5 to
85a6361
Compare
|
Code Climate has analyzed commit 85a6361 and detected 0 issues on this pull request. View more on Code Climate. |
|
Implemented in release 0.6.6 |
No description provided.