From spack/develop: crtm: add v3.1.1-build1 (spack #48451) #501
Conversation
* add [email protected] * fix url_for_version's version check Co-authored-by: Tamara Dahlgren <[email protected]> --------- Co-authored-by: Tamara Dahlgren <[email protected]>
| @@ -51,6 +51,9 @@ class Crtm(CMakePackage): | |||
|
|
|||
| license("CC0-1.0") | |||
|
|
|||
| version( | |||
There was a problem hiding this comment.
@BenjaminTJohnson For previous versions of CRTM (the _emc flavor, we had the following dependencies:
depends_on("[email protected]_emc", when="@2.3.0 +fix")
depends_on("[email protected]_emc", when="@=2.4.0 +fix")
depends_on("[email protected]_emc", when="@2.4.0.1 +fix")
The variant fix is still defined for [email protected], but no fix files are associated with this version. Is this variant no longer needed (i.e. no fix files needed), or do we also need to add a new version of crtm-fix and the dependency here?
Thanks.
There was a problem hiding this comment.
There was a problem hiding this comment.
@BenjaminTJohnson would be the right person to answer this question.
If I understood correctly, we are aiming to avoid agency specific releases. All users are expected to use the same fix folder with crtm model releases. I could be wrong for this specific case, so let's wait for Ben (currently at AMS).
There was a problem hiding this comment.
Ok, thanks. If that new fixed-file tarball is available from somewhere, then I can configure the variant correctly here (we need to also fix the crtm package in spack develop in this case).
There was a problem hiding this comment.
@BenjaminTJohnson Is that tarball with the new fixed files available from somewhere for 3.1.1-build1 (to pull down separately, aka EMC method), or does that get pulled down automatically during the build (aka JCSDA method)? Thanks!
Note
Do not merge yet - resolve question #501 (comment) first
Description
Add [email protected] (from spack develop)
Testing
See CI below and JCSDA/spack-stack#1454