Update ESMF to support clang with gfortran and clang with flang (spack #48026); replace [email protected] with [email protected] #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ang with gfortran and clang with flang
… feature/esmf_clang_flang
theurich
reviewed
Dec 13, 2024
Ok, fine with me. |
|
@climbfuji https://github.com/esmf-org/esmf/releases/tag/v8.8.0b10 is available. This is the feature frozen code for the upcoming official ESMF 8.8.0 release. |
climbfuji
changed the title
climbfuji
changed the title
7 tasks
theurich
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far, the ESMF package recipe in spack assumes that the spack compilers clang and apple-clang are using gfortran as the Fortran compiler. But with the latest improvements to the LLVM compilers, we need to also support clang with flang. See spack#48026 for more information and feedback from the package maintainers and spack developers if there's a better way (PR was reviewed and merged Dec 11, 2024).
Also add
[email protected](seems to be necessary for LLVM 19.1.4; regardless, both NEPTUNE and UFS need this version).See JCSDA/spack-stack#1409 for the corresponding spack-stack PR (this PR has some unrelated changes = cleanup on Derecho and is therefore still in draft; however, ESMF works as expected in CI and my manual testing with LLVM 19.1.4 on my dev machine).