Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When chaining against chained envs, get upstreams+envrepo's #1396

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Dec 6, 2024

Summary

This PR makes the env chaining logic in spack stack create env --upstream more robust, specifically by recursively checking to see whether the upstream environments are themselves chained environments and adding those to the new environment's list of upstreams. It also automatically populates an envrepo/ repo directory from those found in the upstream environments.

I've tried to support a couple users now in chaining against, e.g., upp-addon-env, and it quickly gets complicated/manual labor-intensive, so these changes should make it much easier for developers to deploy their own test environments.

Testing

Tested on personal machine & Gaea C5. Includes unit testing.

Applications affected

GSI, UWM, UPP, and anything else that uses addon envs.

Systems affected

all

Dependencies

none

Issue(s) addressed

none

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

Copy link
Collaborator

@srherbener srherbener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm not expert in the chained environment feature. Thanks for adding this in!

@climbfuji climbfuji enabled auto-merge (squash) December 9, 2024 18:00
@climbfuji climbfuji disabled auto-merge December 9, 2024 21:38
@climbfuji climbfuji merged commit 788ba64 into JCSDA:develop Dec 9, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants