Redefine variants in neptune-env virtual package #1265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR defines three variants in the
neptune-env
virtual package:espc
,python
,xnrl
. In the unified environment and in the skylab environment, the variantsespc
andxnrl
are off, thepython
variant is on. This is so thatpy-fortranformat
is available in those environments (required bypyiri-jedi
). In the neptune standalone environment, all three variants are on. Note that thexnrl
variant requires thepython
variant.We can debate if we should move some of the Python packages from the
python
variant to thexnrl
variant, but since these are in the unified environment anyway (because some other package needs them), it doesn't really matter.Testing
I concretize the neptune standalone environment and the unified environment on my laptop and verified that there are no duplicate packages or conflicts. I also tested that specifying
+xnrl ~python
throws an error. Further testing will be done in CI (see below).Applications affected
There are no changes to the neptune standalone environment, only to the unified environment and the skylab environment (if that is still used).
Systems affected
n/a
Dependencies
n/a
Issue(s) addressed
Need
py-fortranformat
in unified environment.Checklist
All dependency PRs/issues have been resolved and this PR can be merged.