-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add py-fortranformat to neptune-env #1258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me. Just want to confirm that the python variant in the unified environment stays off for now (because of version conflicts that we've been getting on several systems).
@climbfuji - Yes I confirmed in my build that the python variant is not built unless I manually edit the spack yaml before running concretize and install. That means that even after this change, fortranformat will be unavailble on any platform using our unified-dev environment. How are we going to service users dependent on this package? Are there platforms where we build the Adding @huishao-r for her thoughts on this ↑ |
We can't build the Python variant of neptune-env as is in the unified environment for two reasons:
We build neptune-env+python as part of the neptune-dev (NEPTUNE standalone) template on Navy machines (Narwhal, Nautilus, Atlantis, Sandy) regularly. Can't build anywhere else because of the xnrl business mentioned above. Suggested way forward: split the python variant in neptune-env into two parts, one with basic utilities (incl. the new fortranformat) that concretize fine within the unified environment, and one with the more complicated utilities incl xnrl. If this sounds like a good idea, I will take care of it. |
@climbfuji I agree with the approach you mentioned, also that explains why I have variant/version duplicates in my concretize.
|
Let's merge this then and let me work on a follow-up PR. |
Add the package py-fortranformat to neptune-env. Note that neptune-env as loaded by the unified environment template is the ~python variant so this package had to be modified manually.
Testing
This was tested un a Ubuntu system. Testing is ongoing and I'll update this PR from a draft to a full PR when testing is done.
Issue(s) addressed
Fixes #1229
Note the container update will be made in a separate PR.
Checklist