Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py-fortranformat to neptune-env #1258

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

eap
Copy link
Collaborator

@eap eap commented Aug 20, 2024

Add the package py-fortranformat to neptune-env. Note that neptune-env as loaded by the unified environment template is the ~python variant so this package had to be modified manually.

Testing

This was tested un a Ubuntu system. Testing is ongoing and I'll update this PR from a draft to a full PR when testing is done.

Issue(s) addressed

Fixes #1229
Note the container update will be made in a separate PR.

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me. Just want to confirm that the python variant in the unified environment stays off for now (because of version conflicts that we've been getting on several systems).

@eap eap requested a review from huishao-r August 21, 2024 15:50
@eap
Copy link
Collaborator Author

eap commented Aug 21, 2024

@climbfuji - Yes I confirmed in my build that the python variant is not built unless I manually edit the spack yaml before running concretize and install. That means that even after this change, fortranformat will be unavailble on any platform using our unified-dev environment.

How are we going to service users dependent on this package? Are there platforms where we build the +python variant neptune environment? Alternatively, should we be putting this into a different meta package?

Adding @huishao-r for her thoughts on this ↑

@eap eap marked this pull request as ready for review August 21, 2024 15:51
@climbfuji
Copy link
Collaborator

@climbfuji - Yes I confirmed in my build that the python variant is not built unless I manually edit the spack yaml before running concretize and install. That means that even after this change, fortranformat will be unavailble on any platform using our unified-dev environment.

How are we going to service users dependent on this package? Are there platforms where we build the +python varient neptune environment? Alternatively, should we be putting this into a different meta package?

Adding @huishao-r for her thoughts on this ↑

We can't build the Python variant of neptune-env as is in the unified environment for two reasons:

  1. py-xnrl is a code with restricted access; the code lives in the NRL enterprise github
  2. Also, some of the dependencies of py-xnrl listed explicitly in the variant caused version conflicts in the past with the other complex python environments from JEDI and the UFS

We build neptune-env+python as part of the neptune-dev (NEPTUNE standalone) template on Navy machines (Narwhal, Nautilus, Atlantis, Sandy) regularly. Can't build anywhere else because of the xnrl business mentioned above.

Suggested way forward: split the python variant in neptune-env into two parts, one with basic utilities (incl. the new fortranformat) that concretize fine within the unified environment, and one with the more complicated utilities incl xnrl. If this sounds like a good idea, I will take care of it.

@eap
Copy link
Collaborator Author

eap commented Aug 21, 2024

@climbfuji I agree with the approach you mentioned, also that explains why I have variant/version duplicates in my concretize.

@climbfuji
Copy link
Collaborator

Let's merge this then and let me work on a follow-up PR.

@climbfuji climbfuji merged commit 887763c into JCSDA:develop Aug 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INSTALL]: fortranformat Python package
2 participants