Skip to content

Commit

Permalink
Use the mode from the jpeg stream (#70)
Browse files Browse the repository at this point in the history
* disable jpeg encode warning when lossless_jpeg=True

* use the mode from the reconstructed jpeg
  • Loading branch information
Piezoid authored Oct 11, 2024
1 parent 1719d2f commit 58f14c2
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 11 deletions.
27 changes: 17 additions & 10 deletions pillow_jxl/JpegXLImagePlugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,15 @@ def _open(self):
if self.jpeg:
with Image.open(BytesIO(self._data)) as im:
self._data = im.tobytes()
self._size = (self._jxlinfo.width, self._jxlinfo.height)
self.rawmode = self._jxlinfo.mode
self.info["icc_profile"] = icc_profile
self._size = im.size
self.rawmode = im.mode
self.info = im.info
icc_profile = im.info.get("icc_profile", icc_profile)
else:
self._size = (self._jxlinfo.width, self._jxlinfo.height)
self.rawmode = self._jxlinfo.mode
if icc_profile:
self.info["icc_profile"] = icc_profile
# NOTE (Isotr0py): PIL 10.1.0 changed the mode to property, use _mode instead
if parse(PIL.__version__) >= parse("10.1.0"):
self._mode = self.rawmode
Expand Down Expand Up @@ -98,7 +104,7 @@ def _save(im, fp, filename, save_all=False):
effort = info.get("effort", 7)
use_container = info.get("use_container", False)
use_original_profile = info.get("use_original_profile", False)
jpeg_encode = info.get("lossless_jpeg", True)
jpeg_encode = info.get("lossless_jpeg", None)
num_threads = info.get("num_threads", -1)

enc = Encoder(
Expand All @@ -113,12 +119,13 @@ def _save(im, fp, filename, save_all=False):
)
# FIXME (Isotr0py): im.filename maybe None if parse stream
# TODO (Isotr0py): This part should be refactored in the near future
if im.format == "JPEG" and im.filename and jpeg_encode:
warnings.warn(
"Using JPEG reconstruction to create lossless JXL image from JPEG. "
"This is the default behavior for JPEG encode, if you want to "
"disable this, please set 'lossless_jpeg' to False."
)
if im.format == "JPEG" and im.filename and (jpeg_encode or jpeg_encode is None):
if jpeg_encode is None:
warnings.warn(
"Using JPEG reconstruction to create lossless JXL image from JPEG. "
"This is the default behavior for JPEG encode, if you want to "
"disable this, please set 'lossless_jpeg'."
)
with open(im.filename, "rb") as f:
data = enc(f.read(), im.width, im.height, jpeg_encode=True)
else:
Expand Down
2 changes: 1 addition & 1 deletion test/test_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def test_encode(image):
def test_jpeg_encode():
temp = tempfile.mktemp(suffix=".jxl")
img_ori = Image.open("test/images/sample.jpg")
img_ori.save(temp, lossless=True)
img_ori.save(temp, lossless=True, lossless_jpeg=True)

img_enc = Image.open(temp)
assert img_ori.size == img_enc.size == (40, 50)
Expand Down

0 comments on commit 58f14c2

Please sign in to comment.