Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming and visibility #2

Merged
merged 15 commits into from
Nov 16, 2023
Merged

Naming and visibility #2

merged 15 commits into from
Nov 16, 2023

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Nov 15, 2023

Still have to work on visibility for a Rust consumer as some necessary types are hidden in private modules

Also open question about if we re-rename AlloyError to IroncoreAlloyError

@giarc3 giarc3 requested review from a team as code owners November 15, 2023 00:08
@giarc3 giarc3 requested review from BobWall23 and removed request for a team November 15, 2023 00:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

File Coverage Lines
All files 60% 60% ✅

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 0b5a244

skeet70
skeet70 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@skeet70 skeet70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's here looks good. I haven't done my own pass yet to see if anything is missing.

RELEASING.md Show resolved Hide resolved
core/README.md Outdated Show resolved Hide resolved
core/python/ironcore-alloy/README.md Outdated Show resolved Hide resolved
core/README.md Outdated Show resolved Hide resolved
core/src/errors.rs Show resolved Hide resolved
coltfred
coltfred approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start for sure. Tested locally and it seems to be working.

@skeet70 skeet70 merged commit 28ab055 into main Nov 16, 2023
9 checks passed
@skeet70 skeet70 deleted the naming branch November 16, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeet70 skeet70 skeet70 approved these changes

@coltfred coltfred coltfred approved these changes

@BobWall23 BobWall23 Awaiting requested review from BobWall23 BobWall23 is a code owner automatically assigned from IronCoreLabs/ops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giarc3 @coltfred @skeet70