Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 140] Examples: demonstrate WildFly with Keycloack SAML adapter Galleon Pack s2i provisioning with Intersmash #152

Merged

Conversation

fabiobrz
Copy link
Member

@fabiobrz fabiobrz commented Feb 26, 2024

Description

An example that demonstrates provisioning WildFly on OpenShift via the s2i based image provisioner

Is related to #140

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is self-descriptive and/or documented
  • N/A I have implemented unit tests to cover my changes
  • I tested my code in OpenShift

@fabiobrz fabiobrz force-pushed the demo.add-wildfly-saml-adapter-layer branch 5 times, most recently from b260d91 to 02c9b32 Compare March 4, 2024 11:35
@fabiobrz fabiobrz changed the title Demo.add wildfly saml adapter layer [issue 140] Examples: demonstrate WildFly with Keycloack SAML adapter Galleon Pack s2i provisioning with Intersmash Mar 4, 2024
@fabiobrz
Copy link
Member Author

fabiobrz commented Mar 4, 2024

/retest

@fabiobrz fabiobrz force-pushed the demo.add-wildfly-saml-adapter-layer branch from 02c9b32 to dadbd20 Compare March 6, 2024 06:46
@fabiobrz
Copy link
Member Author

fabiobrz commented Mar 6, 2024

/retest

…ting a WildFly application service on Openshift, configured with the Keycloak SAML adapter layer
@fabiobrz fabiobrz force-pushed the demo.add-wildfly-saml-adapter-layer branch from dadbd20 to 85159f1 Compare March 6, 2024 21:47
@fabiobrz
Copy link
Member Author

fabiobrz commented Mar 7, 2024

/retest

import org.junit.jupiter.api.Test;

@Intersmash(@Service(KeycloakCapableImageBasedWildflyApplication.class))
public class KeycloakCapableImageBasedWildflyApplicationTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiobrz I don't understand how is this supposed to work when we don't have an actual Keycloak server....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed earlier, this is a WildFly service example, no Keycloak in place.
The only thing related to Keycloak is that the configuration of the Galleon-provisioned server includes the Keycloak SAML Adapter Galleon layer.

@tommaso-borgato
Copy link
Collaborator

LGTM, merging

@tommaso-borgato tommaso-borgato merged commit cc13cd3 into Intersmash:main Mar 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants