Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ClipboardMessage class from Kotlin to Java #13

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

TheMeinerLP
Copy link
Member

Proposed changes

ClipboardMessage class has been migrated from Kotlin to Java corresponding changes were made to the SyncService class. The code uses TypedJsonJacksonCodec instead of JsonJacksonCodec and direct getter methods were used for extracting userId and fromServer data from the message. The uncaught exceptions also now handled properly.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

ClipboardMessage class has been migrated from Kotlin to Java corresponding changes were made to the SyncService class. The code uses TypedJsonJacksonCodec instead of JsonJacksonCodec and direct getter methods were used for extracting userId and fromServer data from the message. The uncaught exceptions also now handled properly.
@TheMeinerLP TheMeinerLP requested a review from a team as a code owner December 11, 2023 13:02
The JsonTypeInfo annotation, meant for handling polymorphic types in Jackson, was removed from ClipboardMessage.java. This change simplifies the class definition, as this feature was not needed for this particular Java class.
The success message for clipboard transfer in SyncService.kt has been updated to use correct grammar. Now, after a successful transfer, it will inform the player that the clipboard "was successfully transferred to this server".
Copy link
Member

@OneLiteFeather OneLiteFeather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're fine

@TheMeinerLP TheMeinerLP merged commit 4a75e10 into main Dec 11, 2023
6 checks passed
@TheMeinerLP TheMeinerLP deleted the bugfix/sync-service-and-exception-handling branch December 11, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants