removed legacy network device #13683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jan 15, 2025
| @@ -466,7 +445,7 @@ int main(int argc, const char** argv) try | |||
|
|
|||
| float line_h = ImGui::GetTextLineHeightWithSpacing() + 2; | |||
| float separator_h = new_devices_count > 1 ? ImGui::GetStyle().ItemSpacing.y : 0; | |||
| float popup_select_h = line_h * ( new_devices_count + multiline_devices_names ) + separator_h + ( is_ip_device_connected ? 0 : line_h ); | |||
| float popup_select_h = line_h * ( new_devices_count + multiline_devices_names ) + separator_h ; | |||
There was a problem hiding this comment.
Dont we need to add line_h?
There was a problem hiding this comment.
It was initially a bit confusing, but by default, is_ip_device_connected is set to false. And, displaying the 'Add Network Device' option requires is_ip_device_connected to remain false. In this case, we add line_h to the select dropdown.
There was a problem hiding this comment.
Not sure I understand the effect on the UI.
Are you OK with that?
If you think this is correct I will back off and approve :)
There was a problem hiding this comment.
Yes, and I double-checked just in case, and it looks good this way. If I were to add line_h, the "Add Sources" dropdown popup would end up with a redundant empty line.
Nir-Az
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on : [LRS-1220]