Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't nullify on_frame_ready lambda #13650

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

OhadMeir
Copy link
Contributor

@OhadMeir OhadMeir commented Jan 2, 2025

Tracked on [RSDEV-3022]

We have experienced segmentation faults on Linux while running a start-stop loop test.
Root cause of the problem is handling frame callback in one thread, while stopping in another. Stop deleted the lambda expression calling the user callback, returning from the callback have issued the fault.

@OhadMeir OhadMeir requested review from Nir-Az and maloel January 2, 2025 13:08
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I assume this is tested and better?

@maloel
Copy link
Collaborator

maloel commented Jan 2, 2025

Also, please describe the problem and suspected root-cause in the description.

@OhadMeir
Copy link
Contributor Author

OhadMeir commented Jan 2, 2025

Also, please describe the problem and suspected root-cause in the description.

OK. It is described in the Jira ticket by I will also add a short description here.

@Nir-Az Nir-Az closed this Jan 7, 2025
@Nir-Az Nir-Az reopened this Jan 7, 2025
@OhadMeir OhadMeir merged commit ce21607 into IntelRealSense:development Jan 7, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants