fix: CloudDedicated database creation ignores the given name #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 85.01% 79.21% -5.80%
==========================================
Files 14 14
Lines 1121 1121
==========================================
- Hits 953 888 -65
- Misses 139 203 +64
- Partials 29 30 +1 ☔ View full report in Codecov by Sentry. |
bednar
requested changes
Aug 22, 2024
Comment on lines
+96
to
+101
| if db.ClusterDatabaseName == "" { | ||
| if d.client.config.Database == "" { | ||
| return errors.New("database name must not be empty") | ||
| } | ||
| db.ClusterDatabaseName = d.client.config.Database |
There was a problem hiding this comment.
Describe this behaviour in function documentation.
There was a problem hiding this comment.
Sure, but before doing it, I'm considering whether this fallback may be unexpected for users. Do you think this behavior should be left with documentation, or should we just drop it?
There was a problem hiding this comment.
Keep this fallback and update documentation.
There was a problem hiding this comment.
Addressed with eea7b21
bednar
force-pushed
the
fix-db-creation
branch
from
eea7b21 to
f72bdfd
Compare
bednar
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Cloud Dedicated database creation ignores the database name given by an argument, but applies the database name within client configuration. This behavior differs from the API spec and user intuitions, so I'd say it's a bug.
Checklist