Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LPBatcher issue - lines longer than the buffer size lead to emitting 0 size packets and unemptied buffer #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: LPBatcher issue - lines longer than the buffer size lead to emitting 0 size packets and unemptied buffer #127

wants to merge 2 commits into from

Conversation

karel-rehor
Copy link
Contributor

Proposed Changes

Motivated by EAR 5762

In LPBatcher.emitBytes()

  • Check whether the first line exceeds the buffer size.
  • If it does, just emit the first line and adjust the buffer accordingly
  • If not, proceed with emitting the packet and correct the buffer as before

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlastahajek vlastahajek Awaiting requested review from vlastahajek

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karel-rehor