fix: response body after HTTP error should be closed #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 85.32% 85.35% +0.03%
==========================================
Files 14 14
Lines 1124 1127 +3
==========================================
+ Hits 959 962 +3
Misses 137 137
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bednar
requested changes
Sep 26, 2024
CHANGELOG.md
Outdated
Comment on lines
3
to
10
| ### Features | ||
|
|
||
| 1. [#105](https://github.com/InfluxCommunity/influxdb3-go/pull/105): Support newlines in tag values. | ||
|
|
||
| ### Bug Fixes | ||
|
|
||
| 1. [#106](https://github.com/InfluxCommunity/influxdb3-go/pull/106): Close `resp.Body` after HTTP error response is encountered. | ||
|
|
vlastahajek
reviewed
Sep 26, 2024
influxdb3/client.go
Outdated
Comment on lines
191
to
198
| closingErr := resp.Body.Close() | ||
| if closingErr != nil { | ||
| slog.Warn(fmt.Sprintf("Failed to close response body on HTTP Error(%s): %s", | ||
| err.Error(), | ||
| closingErr.Error())) | ||
| } else { | ||
| slog.Debug(fmt.Sprintf("Closed response body on HTTP Error(%s)", err.Error())) | ||
| } |
There was a problem hiding this comment.
Move closing of the response body to the resolveHTTPError method and omit useless logging. As it is in the InfluxDB Go Client v2
There was a problem hiding this comment.
Moved, and corresponding tests have been removed.
vlastahajek
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102
Proposed Changes
client.resolveHttpErrorreturns an error, ensure thatresp.Body.Close()gets called. Otherwise resources may be leaked.Checklist