fix: PROJECT_ID exposed as an env value just like INFISICA_TOKEN #2912 #2976
+131
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses issue #2912 by exposing PROJECT_ID as an environment variable, similar to how INFISICAL_TOKEN is handled. This enhancement improves the developer experience by enabling users to configure the PROJECT_ID through environment variables, streamlining workflows and making it easier to manage configurations in CI/CD pipelines.
Type ✨
Tests 🛠️
The following tests were conducted to verify the changes:
Default Behavior:
Verified that the application continues to function as expected when PROJECT_ID is not set as an environment variable.
Environment Variable Usage:
Set the PROJECT_ID as an environment variable and ensured that the application correctly utilized the value.
Priority Check:
Tested scenarios where both the environment variable and CLI flag for projectId were provided to confirm that the CLI flag takes precedence.
Invalid Inputs:
Verified that invalid or missing PROJECT_ID values are properly handled with relevant error messages.