Feature(Backend): Secret Syncs #2952
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhilmhdh
requested changes
Jan 8, 2025
| db.ref("updatedAt").withSchema(TableName.AppConnection).as("connectionUpdatedAt") | ||
| ); | ||
|
|
||
| const appendTableName = (filterObj: object): SecretSyncFindFilter => |
There was a problem hiding this comment.
Careful!! I feel this may cause more issues. Just a note
There was a problem hiding this comment.
left comments, will make generic at some point down the road!
|
Need to do application testing - But i guess don't have the UI in this one. I'll read the sync part once again later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR contains the proposed backend for Secret Syncs (Integrations v2). Secret Syncs utilize App Connections to sync, import, and erase secrets from third-party services. AWS Parameter Store with minimal configuration has been used to demonstrate functionality and backend/data structure.
Also includes minor refactoring/additions to App Connections and Org Permissions. App Connections now have
Connectpermission with conditions.enable
appConnectionsfeature flag to preview.Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets