-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow INFISICAL_URL to use domain for self-hosted #242
Conversation
Interesting feature! Imagine you have several projects locally and each of them uses a different Infisical instance/URL, how about the possibility to use a global config file instead, e.g. scoped on the file path? Here's an idea, including what you might want to do as well : #243 |
@Grraahaam I like your idea, but sadly what you are suggesting wouldn't help in the case of global usage which is what I was looking for here. What if you don't have a project setup yet at all? I think having both options would be neat in the long run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awsome PR! A lot of folks have asked for this. Let me know if you have ideas for further improving the CLI
My bad I forgot to mention this use case 🙃 , but it'd also be possible to define it globally, here's an example (updated in the PR as well) : {
"scope": [
"/": {
"token": "secret-xxxxxxxxxxx-xxxxxxxxxxxx-xxxxxxx",
"api-host": "https://app.infisical.com/api",
"dashboard-host": "https://app.infisical.com/dashboard",
"project": "project-global",
"env": "dev",
}
] Thanks for pointing this out! Does that sounds more like what you're expecting? 🤔 |
@Grraahaam that still isn't flexible enough for my use case. I need to be able to change it quickly between runs and I'd prefer not having to use a tool like jq or something to edit a config file constantly. |
Description
Updates the cli to allow for an environment variable named
INFISICAL_URL
this way when a self hosted user is using the CLI they don't need to specify the domain over and over.The order of respect for domains is as follows
Infisical Cloud Domain -> Environment Variable -> CLI Argument
This way the CLI argument can always override even the environment variable.