Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brightness icon when swiping to close flashlight #1907

Closed
wants to merge 2 commits into from

Conversation

serosi
Copy link

@serosi serosi commented Nov 8, 2023

module: DisplayApp.cpp

Fixed #1751: when swiping to close flashlight, the brightness icon now resets to the actual brightness instead of the flashlight's brightness.

Copy link

github-actions bot commented Nov 8, 2023

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed

@FintasticMan FintasticMan added the bug Something isn't working label Nov 16, 2023
@JF002
Copy link
Collaborator

JF002 commented Aug 18, 2024

The original issue was fixed by a refactoring of the brightness introduced by the always on feature #1869. Closing this one.

Thanks for your contribution @serosi 🥇

@JF002 JF002 closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brightness icon changes to flashlight's brightness when flashlight is closed by swipe
3 participants